To me there are two ways to judge a Presidency. As a political scientist, I can say so far he has been successful in that many policy ideas have been implemented. Policies can be a failure but if he is strong enough to implement them he is a success. And that brings me to the other side. As a historian, it is way too early to tell if he is a success. There are too many short and long term things we cannot decide in this moment. The trade war can backfire. The tax cuts could lead to a crippling debt position (in a few years we will be spending more on debt service than on defense, that is not good). Gamble v US is a huge case for SCOTUS, and frankly if Kavanaugh turns out to be the deciding vote for Gamble he is a piece of shit, forget the pardon issues, it would be a blow to Federalism and that would make him a fvcker in and of itself, not to mention the serious implications for fighting crime, which would make Trump a fvcker (Trump is too simple to understand the bigger picture, he would just be happy he could save his buddies from state prosecutions with a pardon, which is what liberals are squawking about, but a serious student of law and government can plainly see the broader implications). Kavanaugh was always a little too favorable for executive power for me but I could overlook that, let's hope he doesn't feel he needs to give a gift to his benefactor, I am less trusting after his partisan outburst. Foreign policy decisions could trigger a war with Iran, which might not be pretty (Iran has some serious Russian tech). Kim could be playing Trump and nuke the shit out of South Korea. Regardless of political beliefs between the two of us, there are a lot of things that could go wrong. If you view politics as "winning or losing" in the moment you miss the big picture, which takes a while.
As a political scientist I think Obama's first term was badass. As a historian I can tell you the verdict is in and the ACA is a failure. That's just how it works.
And it could all work out fine and Trump is still garbage as a human being. He makes JFK and Nixon look like saints, which is saying something. History will judge that as well.